Skip to content

Add period argument to extrinsics calls#2857

Merged
basfroman merged 101 commits intostagingfrom
feat/roman/add-period-to-extrinsics-calls
May 2, 2025
Merged

Add period argument to extrinsics calls#2857
basfroman merged 101 commits intostagingfrom
feat/roman/add-period-to-extrinsics-calls

Conversation

@basfroman
Copy link
Collaborator

@basfroman basfroman commented May 2, 2025

Includes:

  • to all extrinsics and related subtensor calls added period argument. This argument defines the number of blocks during which a transaction remains valid after submission to the chain.
  • now all signing of extrinsics goes in one place in async/subtensor. This will allow us to support, maintain and debug development process much easily.
  • reduced duplication in code.
  • some bugs fixed.
  • refactoring.
  • unit tests are updated.

The main goal was to add new logic without changing the behavior of e2e tests.

  • achieved ✅

Roman added 30 commits April 30, 2025 19:01
@basfroman basfroman linked an issue May 2, 2025 that may be closed by this pull request
@basfroman basfroman requested a review from a team May 2, 2025 08:13
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code's good, but please don't ever use that English language plugin again.

@basfroman basfroman requested a review from thewhaleking May 2, 2025 15:22
@basfroman basfroman merged commit c754b68 into staging May 2, 2025
125 checks passed
@basfroman basfroman deleted the feat/roman/add-period-to-extrinsics-calls branch May 2, 2025 15:58
@ibraheem-abe ibraheem-abe mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add period or era object as argument to all extrinsic

2 participants