Rename argument fallback_chains to fallback_endpoints#2880
Merged
Rename argument fallback_chains to fallback_endpoints#2880
fallback_chains to fallback_endpoints#2880Conversation
ibraheem-abe
previously approved these changes
May 15, 2025
thewhaleking
requested changes
May 15, 2025
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Well, two things. The first is the suggestion.
The second is that we can't rename it without a major version change.
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
thewhaleking
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of the
fallback_chainsargument in its description confuses users. They perceive it as a list of network names, not endpoints.The current changes bring clarity and transparency.