Skip to content

Replace transfer_allow_death with transfer_keep_alive #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basfroman merged 2 commits into from
May 29, 2025
Merged

Replace transfer_allow_death with transfer_keep_alive #2900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bfdae4
replace `transfer_allow_death` with `transfer_keep_alive`
May 29, 2025
e12b20f
update tests
May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bittensor/core/async_subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2322,7 +2322,7 @@ async def get_transfer_fee(

call = await self.substrate.compose_call(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": dest, "value": value.rao},
)

Expand Down
2 changes: 1 addition & 1 deletion bittensor/core/extrinsics/asyncex/transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async def _do_transfer(
"""
call = await subtensor.substrate.compose_call(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": destination, "value": amount.rao},
)

Expand Down
2 changes: 1 addition & 1 deletion bittensor/core/extrinsics/transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def _do_transfer(
"""
call = subtensor.substrate.compose_call(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": destination, "value": amount.rao},
)

Expand Down
2 changes: 1 addition & 1 deletion bittensor/core/subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1831,7 +1831,7 @@ def get_transfer_fee(self, wallet: "Wallet", dest: str, value: Balance) -> Balan
value = check_and_convert_to_balance(value)
call = self.substrate.compose_call(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": dest, "value": value.rao},
)

Expand Down
6 changes: 3 additions & 3 deletions tests/unit_tests/extrinsics/asyncex/test_transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async def test_do_transfer_success(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_awaited_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_destination, "value": fake_amount.rao},
)

Expand Down Expand Up @@ -77,7 +77,7 @@ async def test_do_transfer_failure(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_awaited_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_destination, "value": fake_amount.rao},
)

Expand Down Expand Up @@ -124,7 +124,7 @@ async def test_do_transfer_no_waiting(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_awaited_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_destination, "value": fake_amount.rao},
)

Expand Down
6 changes: 3 additions & 3 deletions tests/unit_tests/extrinsics/test_transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def test_do_transfer_is_success_true(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_called_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
)
subtensor.sign_and_send_extrinsic.assert_called_once_with(
Expand Down Expand Up @@ -64,7 +64,7 @@ def test_do_transfer_is_success_false(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_called_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
)
subtensor.sign_and_send_extrinsic.assert_called_once_with(
Expand Down Expand Up @@ -103,7 +103,7 @@ def test_do_transfer_no_waits(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_called_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
)
subtensor.sign_and_send_extrinsic.assert_called_once_with(
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/test_async_subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ async def test_get_transfer_fee(subtensor, fake_wallet, mocker, balance):
mocked_compose_call.assert_awaited_once()
mocked_compose_call.assert_called_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={
"dest": fake_dest,
"value": fake_value.rao,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/test_subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,7 +1877,7 @@ def test_get_transfer_fee(subtensor, fake_wallet, mocker):
# Asserts
subtensor.substrate.compose_call.assert_called_once_with(
call_module="Balances",
call_function="transfer_allow_death",
call_function="transfer_keep_alive",
call_params={"dest": fake_dest, "value": value.rao},
)

Expand Down
Loading