Conversation
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
This should probably be a new method. Otherwise this looks like a breaking change to me.
added 2 commits
July 18, 2025 08:00
Collaborator
Author
good point just about old blocks |
thewhaleking
previously approved these changes
Jul 18, 2025
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Good, but make sure you deprecate the get_current_weight_commit_info method in subtensor and async_subtensor.
Also, we probably shouldn't merge this yet, as we should merge #2979 and release the patch today.
thewhaleking
approved these changes
Jul 18, 2025
basfroman
deleted the
fix/roman/fix-crv3-tests-after-devnet-ready-get-CRV3WeightCommitsV2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broken test in subtensor pr https://github.com/opentensor/subtensor/actions/runs/16350309250/job/46196105509?pr=1862