Skip to content

Handles both exceptions for Swap pallet fetching #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 1 commit into from
Jul 22, 2025
Merged

Handles both exceptions for Swap pallet fetching #2991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bittensor/core/async_subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ async def all_subnets(

decoded = query.decode()

if not isinstance(subnet_prices, SubstrateRequestException):
if not isinstance(subnet_prices, (SubstrateRequestException, ValueError)):
for sn in decoded:
sn.update(
{"price": subnet_prices.get(sn["netuid"], Balance.from_tao(0))}
Expand Down Expand Up @@ -1155,7 +1155,7 @@ async def get_all_subnets_info(
if not result:
return []

if not isinstance(prices, SubstrateRequestException):
if not isinstance(prices, (SubstrateRequestException, ValueError)):
for subnet in result:
subnet.update({"price": prices.get(subnet["netuid"], 0)})
else:
Expand Down Expand Up @@ -3858,7 +3858,7 @@ async def subnet(
)

if isinstance(decoded := query.decode(), dict):
if isinstance(price, SubstrateRequestException):
if isinstance(price, (SubstrateRequestException, ValueError)):
price = None
return DynamicInfo.from_dict({**decoded, "price": price})
return None
Expand Down
6 changes: 3 additions & 3 deletions bittensor/core/subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ def all_subnets(self, block: Optional[int] = None) -> Optional[list["DynamicInfo
sn.update(
{"price": subnet_prices.get(sn["netuid"], Balance.from_tao(0))}
)
except SubstrateRequestException as e:
except (SubstrateRequestException, ValueError) as e:
logging.warning(f"Unable to fetch subnet prices for block {block}: {e}")

return DynamicInfo.list_from_dicts(decoded)
Expand Down Expand Up @@ -655,7 +655,7 @@ def get_all_subnets_info(self, block: Optional[int] = None) -> list["SubnetInfo"

for subnet in result:
subnet.update({"price": subnets_prices.get(subnet["netuid"], 0)})
except SubstrateRequestException as e:
except (SubstrateRequestException, ValueError) as e:
logging.warning(f"Unable to fetch subnet prices for block {block}: {e}")

return SubnetInfo.list_from_dicts(result)
Expand Down Expand Up @@ -2771,7 +2771,7 @@ def subnet(self, netuid: int, block: Optional[int] = None) -> Optional[DynamicIn
if isinstance(decoded := query.decode(), dict):
try:
price = self.get_subnet_price(netuid=netuid, block=block)
except SubstrateRequestException:
except (SubstrateRequestException, ValueError):
price = None
return DynamicInfo.from_dict({**decoded, "price": price})
return None
Expand Down