[v10] Remove _do* extrinsic calls and combine them with extrinsic logic.#3042
Merged
[v10] Remove _do* extrinsic calls and combine them with extrinsic logic.#3042
_do* extrinsic calls and combine them with extrinsic logic.#3042Conversation
added 10 commits
September 2, 2025 14:49
…v3_extrinsic`, `.commit_reveal_v3_extrinsic` renamed to `.commit_reveal_extrinsic`
…ghts_extrinsic` + fixed/removed tests
Closed
added 12 commits
September 2, 2025 17:19
…ights.py` + cleanup
…inalized.` for `set_weights_extrinsic` bc of test's validator logic works with it
…ister_extrinsic`
…insic` + fixed tests
…_weights_extrinsic` + fixed tests
…ic` + `dest` parameter has been renamed to `destination` in `transfer_extrinsic` function and `subtensor.transfer` method. + fixed tests
basfroman
changed the title
_do* extrinsic calls and combine them with extrinsic logic._do* extrinsic calls and combine them with extrinsic logic.
ibraheem-abe
reviewed
Sep 3, 2025
Contributor
ibraheem-abe
left a comment
ibraheem-abe
left a comment
There was a problem hiding this comment.
Overall lgtm.
Just wanted to confirm the root_set_weights call is relavant
Comment on lines
+115
to
+116
| # TODO: It is worth deleting everything below and simply returning the result without additional verification. This | ||
| # should be the responsibility of the user. We will also reduce the number of calls to the chain. |
Contributor
There was a problem hiding this comment.
Technically yes we should return the result. Remnants of old design.
From the other perspective, its useful to know additional stats in subnets with uid pressure
Collaborator
Author
There was a problem hiding this comment.
I thought about it. Maybe it's worth implementing an additional flag, something like extended_info. If it's passed to True, then calculate. If not, then just silently skip. But I'm still thinking about it. Let's leave it as is in this PR, I'm not deleting anything anyway. I'll come back to this at the TODO processing step.
Does it make sense?
… subtensor calls `subtensor.set_root_weights_extrinsic` removed too.
ibraheem-abe
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Includes:
._do_commit_reveal_v3logic is included in the main code.commit_reveal_v3_extrinsic.commit_reveal_v3_extrinsicrenamed to.commit_reveal_extrinsicrevecommit_reveal_versionparameter with default value4added torevecommit_reveal_version._do_commit_weightslogic is included in the main code.commit_weights_extrinsic._do_reveal_weightslogic is included in the main code.reveal_weights_extrinsic._do_set_weightslogic is included in the main code.set_weights_extrinsicset_weights_extrinsicmoved tobittensor/core/extrinsics/commit_weights.pybittensor/core/extrinsics/commit_weights.pymodule renamed tobittensor/core/extrinsics/weights.py(consistent naming with async module)_do_burned_registerlogic is included in the main code.burned_register_extrinsic_do_pow_registerlogic is included in the main code.register_extrinsic._do_set_root_weightslogic is included in the main code.set_root_weights_extrinsic._do_transferlogic is included in the main code.transfer_extrinsicdestparameter has been renamed todestinationintransfer_extrinsicfunction andsubtensor.transfermethod.Adds:
bittensor/core/extrinsics/transfer.pycovered (used to it was 0%)