Conversation
ibraheem-abe
approved these changes
Sep 3, 2025
basfroman
deleted the
fix/roman/Async-Get_balances-at-a-specific-block-returns-current-block
branch
camfairchild
suggested changes
Sep 3, 2025
Comment on lines
-1238
to
-1239
| elif not block_hash: | ||
| block_hash = await self.get_block_hash() |
Contributor
There was a problem hiding this comment.
How about
elif block_hash is None and block is None:
That way they can specify blockhash without an extra network call.
Also using is None instead of checking for a false-y value because block can be 0
This was referenced Sep 5, 2025
Merged
basfroman
added a commit
that referenced
this pull request
Oct 14, 2025
…-at-a-specific-block-returns-current-block Async Get_balances at a specific block returns current block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3038