Conversation
added 10 commits
September 12, 2025 19:02
added 11 commits
September 12, 2025 21:05
# Conflicts: # bittensor/core/chain_data/metagraph_info.py # tests/e2e_tests/test_incentive.py
added 9 commits
September 19, 2025 07:45
ibraheem-abe
previously approved these changes
Sep 19, 2025
Contributor
ibraheem-abe
left a comment
There was a problem hiding this comment.
Nice work on the backwards compatibility 👍
ibraheem-abe
previously approved these changes
Sep 19, 2025
thewhaleking
previously approved these changes
Sep 22, 2025
Contributor
thewhaleking
left a comment
There was a problem hiding this comment.
Not sure I understand the "Parameters" change. Very inconsistent. In this file, we have:
Parameters: 9
Arguments: 119
Args: 1
This PR is very hard to review because the majority of code changes have nothing to do with the PR.
MichaelTrestman
previously approved these changes
Sep 22, 2025
Contributor
MichaelTrestman
left a comment
There was a problem hiding this comment.
I did not do a thorough code review but can verify that the scripts covered in the docs work with the SDK, behaving appropriately under core use cases.
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
044723f
the same just more obvious, but longer Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
thewhaleking
approved these changes
Sep 22, 2025
ibraheem-abe
approved these changes
Sep 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage:
Note
0).0.-
set_weightsNote
As before,
set_weightsworks with thecommit_reveal_enabledhyperparameter enabled and disabled.-
commit_weights-
reveal_weights-
get_mechanism_countImportant
A new method
-
get_mechanism_emission_splitImportant
A new method
-
bonds-
get_all_metagraphs_infoImportant
Got a new parameter
all_mechanisms: bool = False-
get_metagraph_infoImportant
A very important update without breaking changes to backward compatibility
-
get_timelocked_weight_commits-
metagraphImportant
A very important update without breaking changes to backward compatibility.
Method got new parameter
mechid. By default is0.Metagraphclass has a new fields:mechid: int-0by defaultmechanisms_emissions_split: list[int]- calculated after metagraph initialization, updated upon syncmechanism_count: int- calculated after metagraph initialization, updated upon sync-
weights-
sudo_set_mechanism_count_extrinsicImportant
sudo extrinsic
-
sudo_set_mechanism_emission_split_extrinsicImportant
sudo extrinsic
Subtensor class has new methods:
get_mechanism_countget_mechanism_emission_splitis_in_admin_freeze_windowNext subtensor methods has additional parameter
mechid(by default is0):bondscommit_weightsget_metagraph_infoget_all_metagraphs_info# has a new parameterall_mechanismsget_timelocked_weight_commitsreveal_weightsset_weightsweightsBittensor SDK has a new extrinsics:
commit_mechanism_weights_extrinsiccommit_timelocked_mechanism_weights_extrinsicreveal_mechanism_weights_extrinsicset_mechanism_weights_extrinsicsudo extrinsics (for sudo or SN owners only)
sudo_set_admin_freez_window_extrinsicsudo_set_mechanism_count_extrinsicsudo_set_mechanism_emission_split_extrinsicTo maintain backward compatibility we will keep the following extrinsics, but passibly they will be removed in SDKv10:
set_weights_extrinsiccommit_weights_extrinsicreveal_weights_extrinsiccommit_reveal_v3_extrinsicChain Storages that received an updated
storage_indexinstead of justnetuid:IncentiveLastUpdateWeightsBondsWeightCommitsTimelockedWeightCommitsCRV3WeightCommits(will be deprecated)CRV3WeightCommitsV2(will be deprecated)Related:
Subnet Mechanismslogic #3050Fixed bug:
retriesnever increased in case of error insubtensor.commit_weightsandsubtensor.reveal_weights