[e2e] fix: e2e test for metagraph expected not matching#3137
Closed
camfairchild wants to merge 5 commits intostagingfrom
Closed
[e2e] fix: e2e test for metagraph expected not matching#3137camfairchild wants to merge 5 commits intostagingfrom
camfairchild wants to merge 5 commits intostagingfrom
Conversation
tests/e2e_tests/test_metagraph.py
Outdated
| subnet_emission=Balance(0), | ||
| alpha_in=Balance.from_tao(10).set_unit(1), | ||
| alpha_out=Balance.from_tao(1).set_unit(1), | ||
| alpha_out=Balance.from_tao((1 + block) * alpha_per_block).set_unit(1), # it's been 2 blocks |
Contributor
There was a problem hiding this comment.
Why has it been 2 blocks if we're checking at block 1?
| subtensor.register_subnet(alice_wallet, True, True) | ||
|
|
||
| metagraph_info = subtensor.get_metagraph_info(netuid=1, block=1) | ||
| block = 1 |
Contributor
There was a problem hiding this comment.
Does this need to be block = registration block + 1? Otherwise it's just always using the first block, which is happens before the subnet is even created. But even then we're basically checking a blank slate.
Collaborator
There was a problem hiding this comment.
in this part of the test we compare first blocks
basfroman
added
the
subtensor-localnet:main
basfroman
previously approved these changes
Nov 11, 2025
thewhaleking
previously approved these changes
Nov 11, 2025
basfroman
added
subtensor-localnet:main
basfroman
dismissed stale reviews from thewhaleking and themself
via
2555f65
basfroman
removed
the
subtensor-localnet:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For opentensor/subtensor#2187
We are correcting an issuance with the emission calculation for subnets that are not root selling.
I'm not sure how this was passing before but it's not now.