[hotfix] Fix GPU reg bug. bad indent#883
Merged
robertalanm merged 94 commits intomasterfrom Aug 17, 2022
Merged
Conversation
keeping proc until solution
should have default in CLI call
check registration after failure
* add update interval and num proc flag * add better number output * optimize multiproc cpu reg keeping proc until solution * fix test * make sure to exit properly if registered during * fix tests * change import to use tests * add optional type hints and None default * change to count using allowed processes * add documentation. Fix random start
joeylegere
approved these changes
Aug 17, 2022
robertalanm
approved these changes
Aug 17, 2022
Contributor
robertalanm
left a comment
robertalanm
left a comment
There was a problem hiding this comment.
looks good to me, approving!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the GPU reg bug and adds a test to verify this behaviour.
Thanks @MythicFrost