Merged
Conversation
Contributor
isabella618033
commented
Aug 22, 2022
isabella618033
commented
- axon priority_threadpool not passed through
- remove server's error message on validator side
- server set weight block time to be independent with optimisation step
- axon wasnt timing out at 12 sec
- responsive uid not counted properly
Eugene-hu
reviewed
Aug 22, 2022
Contributor
Eugene-hu
left a comment
Eugene-hu
left a comment
There was a problem hiding this comment.
Looks good! Left a few comments that we need to be careful about
…nsor into BIT-553-timeout_bug_fix
…nsor into BIT-553-timeout_bug_fix
…nsor into BIT-553-timeout_bug_fix
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.