Conversation
Eugene-hu
approved these changes
Sep 1, 2022
Contributor
Eugene-hu
left a comment
There was a problem hiding this comment.
LGTM; left you a comment
Contributor
|
Closing this for new PR that replace this one: #928 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prometheus logging:
Bittensor and miner classes can enable a local Prometheus server that logs statistics. These can be picked up by a global Prometheus server for use in network monitoring.
Features:
Global Prometheus switch
--prometheus.level <DEBUG, INFO, OFF>
Object level Prometheus switches:
--config.promehteus.level <DEBUG, INFO, OFF>
--axon.promehteus.level <DEBUG, INFO, OFF>
--dendrite.promehteus.level <DEBUG, INFO, OFF>
Turning off the global Prometheus switch ensures the main Prometheus server is not created.
Additional changes:
-- Removes defunct wandb statistics logging from Axon and Dendrite and from Validator and Miner classes.