Skip to content

[fix] fixes unstake with max-stake flag #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camfairchild merged 3 commits into from
Sep 6, 2022
Merged

[fix] fixes unstake with max-stake flag #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b2ccab
add equality to None to the balance class
camfairchild Sep 5, 2022
a631140
Merge branch 'nobunaga' into fix/max-stake-unstake
Sep 6, 2022
2b6719d
add tests for the None case
camfairchild Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bittensor/utils/balance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ def __repr__(self):
return self.__str__()

def __eq__(self, other: Union[int, float, "Balance"]):
if other is None:
return False

if hasattr(other, "rao"):
return self.rao == other.rao
else:
Expand Down
9 changes: 9 additions & 0 deletions tests/unit_tests/bittensor_tests/test_balance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,3 +327,12 @@ def test_balance_rfloordiv_other_not_balance(self, balance: Union[int, float], b
assert isinstance(quot_, Balance)
assert CLOSE_IN_VALUE(quot_.rao, 5) == rao2_ // rao_

@given(balance=valid_tao_numbers_strategy)
def test_balance_not_eq_none(self, balance: Union[int, float]):
balance_ = Balance(balance)
assert not balance_ == None

@given(balance=valid_tao_numbers_strategy)
def test_balance_neq_none(self, balance: Union[int, float]):
balance_ = Balance(balance)
assert balance_ != None