Merged
Conversation
basfroman
reviewed
May 9, 2025
camfairchild
reviewed
May 9, 2025
Contributor
camfairchild
left a comment
camfairchild
left a comment
There was a problem hiding this comment.
Should also base it on the path maybe.
I doubt anything else has a length of 32 in a composite like this, but it's more robust.
Contributor
Author
What do you mean? |
basfroman
reviewed
May 9, 2025
camfairchild
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly decodes account Ids (SS58). Also no longer wraps everything in a tuple.
Fixes #16
Considerations: We should probably have a way to set flag this to decode or use the legacy undecoded. Otherwise we'll break backwards compatibility. This should not be released currently, because of this reason.