Skip to content

Account ID improvements#25

Merged
thewhaleking merged 6 commits intomainfrom
feat/thewhaleking/account-id-improvements
May 12, 2025
Merged

Account ID improvements#25
thewhaleking merged 6 commits intomainfrom
feat/thewhaleking/account-id-improvements

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented May 12, 2025 •
edited
Loading

  1. Adds default arg legacy_account_id to decode and decode_list, so as not to break backwards compatibility
  2. Only dumps Account ID strings out of tuples, e.g. '5F27Eqz2PhyMtGMEce898x31DokNqRVxkm5AhDDe6rDGNvoY' vs ('5F27Eqz2PhyMtGMEce898x31DokNqRVxkm5AhDDe6rDGNvoY',) instead of all singleton tuples decoded

@thewhaleking thewhaleking changed the title [WIP] Account ID improvements Account ID improvements May 12, 2025
@thewhaleking thewhaleking marked this pull request as ready for review May 12, 2025 20:29
@thewhaleking thewhaleking requested review from a team and camfairchild May 12, 2025 20:29
@thewhaleking thewhaleking merged commit 3028958 into main May 12, 2025
12 checks passed
@thewhaleking thewhaleking deleted the feat/thewhaleking/account-id-improvements branch May 12, 2025 20:34
@thewhaleking thewhaleking linked an issue May 12, 2025 that may be closed by this pull request
Add Legacy accountid decode option #24
Closed
@thewhaleking thewhaleking mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@camfairchild camfairchild camfairchild approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Legacy accountid decode option

2 participants

@thewhaleking @camfairchild