Skip to content

Remove fuzzy match in wallets.py #462

@thewhaleking

Description

@thewhaleking

This line:

match_ratio = fuzz.ratio(sort_by.lower(), column_name)

causes a number of dependencies: namely fuzzywuzzy and Levenshtein. Levenshtein is a problem, because building from source appears to always install the pure Python SequenceMatcher, so we will get this warning:

.../site-packages/fuzzywuzzy/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')

any time we use btcli if the dependencies are built from source. With packaging for homebrew (#455), everything is built from source, so our two options are: disable the warning or scrap our use of fuzzywuzzy. I think the latter is preferable if we are using multiple dependencies (fuzzywuzzy and Levenshtein) for a single line of code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions