Skip to content

Allow for delegate take between 0 and 18% #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibraheem-abe merged 2 commits into from
Sep 25, 2024
Merged

Allow for delegate take between 0 and 18% #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
011542d
allow for take between 0 and 18%
garrett-opentensor Sep 25, 2024
2cbd0ee
allow for zero take in CLIManager
garrett-opentensor Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bittensor_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2571,7 +2571,7 @@ def root_set_take(
[green]$[/green] btcli root set_take --wallet-name my_wallet --wallet-hotkey my_hotkey
"""
max_value = 0.18
min_value = 0.08
min_value = 0.00
self.verbosity_handler(quiet, verbose)

if not take:
Expand Down
4 changes: 2 additions & 2 deletions bittensor_cli/src/commands/root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,8 +1270,8 @@ async def _do_set_take() -> bool:
)
return False

if take > 0.18 or take < 0.08:
err_console.print("ERROR: Take value should not exceed 18% or be below 8%")
if take > 0.18 or take < 0:
err_console.print("ERROR: Take value should not exceed 18% or be below 0%")
return False

result: bool = await set_take_extrinsic(
Expand Down