Skip to content

Fixed: wallet balance check when undelegating the stake#124

Merged
thewhaleking merged 1 commit intoopentensor:mainfrom
404-Repo:fix/undelegate_balance_check
Sep 26, 2024
Merged

Fixed: wallet balance check when undelegating the stake#124
thewhaleking merged 1 commit intoopentensor:mainfrom
404-Repo:fix/undelegate_balance_check

Conversation

@the-mx
Copy link
Contributor

@the-mx the-mx commented Sep 26, 2024 •
edited
Loading

Changes made:

  1. Wallet balance is checked only for the stake delegate (previous behavior: check wallet balance both for stake and unstake, resulting in error when unstaking amount exceeds the wallet balance).
  2. Log colors aligned for staking and unstacking errors.
  3. Unit tests updated to catch the previous error.

thewhaleking
thewhaleking approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for tests to run before merging.

@thewhaleking thewhaleking merged commit ef2ff8c into opentensor:main Sep 26, 2024
@ibraheem-abe ibraheem-abe mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewhaleking thewhaleking thewhaleking approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@the-mx @thewhaleking