Skip to content

Change network option to a list so that it can be correctly parsed if multiple options are given#165

Merged
thewhaleking merged 3 commits intostagingfrom
feat/thewhaleking/fix-multiple-network-options
Oct 7, 2024
Merged

Change network option to a list so that it can be correctly parsed if multiple options are given#165
thewhaleking merged 3 commits intostagingfrom
feat/thewhaleking/fix-multiple-network-options

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Oct 6, 2024

Allows for using something like btcli w faucet --subtensor.chain_endpoint ws://127.0.0.1:9945 --subtensor.network local and it will correctly interpret it as indicating ws://127.0.0.1:9945.

This isn't the ideal solution for #160, but it is one option.

Now:

bhimes@Benjamins-MacBook-Pro /Users/bhimes/Git/btcli                                                                  feat/thewhaleking/fix-multiple-network-options
⚡ btcli w balance --subtensor.network local --subtensor.chain_endpoint ws://127.0.0.1:9945

Unable to connect to the chain: Network: custom, Chain: ws://127.0.0.1:9945
(venv) 
bhimes@Benjamins-MacBook-Pro /Users/bhimes/Git/btcli                                                                  feat/thewhaleking/fix-multiple-network-options
⚡ btcli w balance --subtensor.network local --subtensor.chain_endpoint ws://127.0.0.1:9945 --network local

Unable to connect to the chain: Network: custom, Chain: ws://127.0.0.1:9945
(venv) 
bhimes@Benjamins-MacBook-Pro /Users/bhimes/Git/btcli                                                                  feat/thewhaleking/fix-multiple-network-options
⚡ btcli w balance --subtensor.chain_endpoint ws://127.0.0.1:9945 --network local 

Unable to connect to the chain: Network: custom, Chain: ws://127.0.0.1:9945
(venv) 
bhimes@Benjamins-MacBook-Pro /Users/bhimes/Git/btcli                                                                  feat/thewhaleking/fix-multiple-network-options
⚡ btcli w balance --network local 

[12:08:38] Warning: Verify your local subtensor is running on port 9944.                                                                        subtensor_interface.py:78
Unable to connect to the chain: Network: local, Chain: ws://127.0.0.1:9444
(venv) 
bhimes@Benjamins-MacBook-Pro /Users/bhimes/Git/btcli                                                                  feat/thewhaleking/fix-multiple-network-options
⚡ btcli w balance                

@thewhaleking thewhaleking changed the base branch from main to staging October 6, 2024 10:13
@thewhaleking thewhaleking marked this pull request as ready for review October 7, 2024 12:56
@thewhaleking thewhaleking linked an issue Oct 7, 2024 that may be closed by this pull request
@thewhaleking thewhaleking merged commit b781384 into staging Oct 7, 2024
@thewhaleking thewhaleking deleted the feat/thewhaleking/fix-multiple-network-options branch October 7, 2024 16:38
@ibraheem-abe ibraheem-abe mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't allow multiple options

2 participants