Skip to content

Remove old commit reveal hyperparameter and add a new one. #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
opendansor wants to merge 1 commit into from
Closed

Remove old commit reveal hyperparameter and add a new one. #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bittensor_cli/src/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ class WalletValidationTypes(Enum):
"kappa": "sudo_set_kappa",
"difficulty": "sudo_set_difficulty",
"bonds_moving_avg": "sudo_set_bonds_moving_average",
"commit_reveal_weights_interval": "sudo_set_commit_reveal_weights_interval",
"commit_reveal_periods": "sudo_set_commit_reveal_weights_periods",
"commit_reveal_weights_enabled": "sudo_set_commit_reveal_weights_enabled",
"alpha_values": "sudo_set_alpha_values",
"liquid_alpha_enabled": "sudo_set_liquid_alpha_enabled",
Expand Down
6 changes: 3 additions & 3 deletions bittensor_cli/src/bittensor/chain_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class SubnetHyperparameters:
max_validators: int
adjustment_alpha: int
difficulty: int
commit_reveal_weights_interval: int
commit_reveal_periods: int
commit_reveal_weights_enabled: bool
alpha_high: int
alpha_low: int
Expand Down Expand Up @@ -119,7 +119,7 @@ def from_vec_u8(cls, vec_u8: bytes) -> Optional["SubnetHyperparameters"]:
max_validators=decoded.max_validators,
adjustment_alpha=decoded.adjustment_alpha,
difficulty=decoded.difficulty,
commit_reveal_weights_interval=decoded.commit_reveal_weights_interval,
commit_reveal_periods=decoded.commit_reveal_periods,
commit_reveal_weights_enabled=decoded.commit_reveal_weights_enabled,
alpha_high=decoded.alpha_high,
alpha_low=decoded.alpha_low,
Expand Down Expand Up @@ -721,7 +721,7 @@ def list_from_vec_u8(cls, vec_u8: bytes) -> list["SubnetInfo"]:
["max_validators", "Compact<u16>"],
["adjustment_alpha", "Compact<u64>"],
["difficulty", "Compact<u64>"],
["commit_reveal_weights_interval", "Compact<u64>"],
["commit_reveal_periods", "Compact<u64>"],
Copy link
Contributor

@thewhaleking thewhaleking Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep note this will be gone in PR #188

["commit_reveal_weights_enabled", "bool"],
["alpha_high", "Compact<u16>"],
["alpha_low", "Compact<u16>"],
Expand Down
2 changes: 1 addition & 1 deletion bittensor_cli/src/commands/weights.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ async def _commit_reveal(
) -> tuple[bool, str]:
interval = int(
await self.subtensor.get_hyperparameter(
param_name="get_commit_reveal_weights_interval",
param_name="get_commit_reveal_periods",
netuid=self.netuid,
reuse_block=False,
)
Expand Down