Skip to content

Warn Users When Setting Root-Only Hyperparams #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 2 commits into from
Feb 25, 2025
Merged

Warn Users When Setting Root-Only Hyperparams #337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b675ca5
Warn users about root-only hyperparams
thewhaleking Feb 25, 2025
b93d038
Merge remote-tracking branch 'origin/staging' into feat/thewhaleking/…
thewhaleking Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bittensor_cli/src/commands/sudo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ async def set_hyperparameter_extrinsic(
":cross_mark: [red]Invalid hyperparameter specified.[/red]"
)
return False
if sudo_:
if not Confirm.ask(
"This hyperparam is only settable by root sudo users. If you are not, this will fail. Please confirm"
):
return False

substrate = subtensor.substrate
msg_value = value if not arbitrary_extrinsic else call_params
Expand Down
Loading