Closed
Conversation
Collaborator
|
Thank you for the contribution! After our chat, I made this PR to fix the issue: #432 We bypass the default behaviour of tolerance Options so the help section wasn't accurately reflecting that. ^ This change should fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The percentage was wrong on rate tolerance 0.05% - it is 5% or 0.05
For safe staking the default param is: [default: no-safe-staking]
So the default is disabled.
Maybe the defaults should be removed from the text for easier maintenance - 2 default parameters is sort of weird:
Enable or disable safe staking mode (default: enabled). [default: no-safe-staking]