Merged
Conversation
…incorrectly assume the entry the user wishes to make. Also correctly snips the leading '0x' from seed hex.
camfairchild
previously approved these changes
May 12, 2025
basfroman
previously approved these changes
May 12, 2025
Contributor
|
I like PR title |
thewhaleking
force-pushed
the
fix/thewhaleking/name-shadowing-bug
branch
from
90c1796 to
f617a19
Compare
thewhaleking
dismissed stale reviews from basfroman and camfairchild
The base branch was changed.
basfroman
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit choosing rather than parsing (for creation type) so as to ensure we do not incorrectly assume the entry the user wishes to make. Also correctly snips the leading '0x' from seed hex.