Skip to content

Subnets Register Improvements #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 3 commits into from
May 15, 2025
Merged

Subnets Register Improvements #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2d745e
Prints failures that arise from subnet register in cases of non-json-…
thewhaleking May 15, 2025
e07fd67
Passes prompt to register extrinsics
thewhaleking May 15, 2025
6fc5c67
Removed `prompt` arg in `root_register_extrinsic`
thewhaleking May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bittensor_cli/src/bittensor/extrinsics/registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,6 @@ async def burned_register_extrinsic(
wait_for_inclusion: bool = True,
wait_for_finalization: bool = True,
era: Optional[int] = None,
prompt: bool = False,
) -> tuple[bool, str]:
"""Registers the wallet to chain by recycling TAO.

Expand Down
1 change: 0 additions & 1 deletion bittensor_cli/src/bittensor/extrinsics/root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ async def root_register_extrinsic(
wallet: Wallet,
wait_for_inclusion: bool = True,
wait_for_finalization: bool = True,
prompt: bool = False,
) -> tuple[bool, str]:
r"""Registers the wallet to root network.

Expand Down
4 changes: 3 additions & 1 deletion bittensor_cli/src/commands/subnets/subnets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,12 +1662,14 @@ async def register(
subtensor,
wallet=wallet,
netuid=netuid,
prompt=False,
old_balance=balance,
era=era,
)
if json_output:
json_console.print(json.dumps({"success": success, "msg": msg}))
else:
if not success:
err_console.print(f"Failure: {msg}")


# TODO: Confirm emissions, incentive, Dividends are to be fetched from subnet_state or keep NeuronInfo
Expand Down
Loading