Skip to content

fix transfer all#562

Merged
thewhaleking merged 2 commits intostagingfrom
fix/thewhaleking/transfer-all
Jul 24, 2025
Merged

fix transfer all#562
thewhaleking merged 2 commits intostagingfrom
fix/thewhaleking/transfer-all

Conversation

@thewhaleking
Copy link
Contributor

Adds a new option to btcli w transfer: --allow-death, which allows death of the account (below the existential deposit) if specified.

Uses different extrinsics depending on what is selected.

Transfer All uses "Balances.transfer_all", with param "keep_alive" toggled depending on --allow-death flag.

Non-Transfer-All with --allow-death uses "Balances.transfer_allow_death"

Non-Transfer-All without --allow-death uses "Balances.transfer_keep_alive"

…s death of the account (below the existential deposit) if specified.
@thewhaleking thewhaleking requested a review from a team July 24, 2025 18:57
@Jackalgirl
Copy link

Probably a dumb question that I'd be able to answer myself if I could read the code, but will --all without --allow-death specified automatically understand to leave the existential deposit?

@thewhaleking
Copy link
Contributor Author

thewhaleking commented Jul 24, 2025

Probably a dumb question that I'd be able to answer myself if I could read the code, but will --all without --allow-death specified automatically understand to leave the existential deposit?

Correct. I just tested it locally, and it indeed leaves 500 rao free

@thewhaleking thewhaleking changed the base branch from staging to fix/thewhaleking/improve-speed-of-fetch-coldkey-hotkey-identities July 24, 2025 19:31
ibraheem-abe
ibraheem-abe previously approved these changes Jul 24, 2025
Copy link
Collaborator

@ibraheem-abe ibraheem-abe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from fix/thewhaleking/improve-speed-of-fetch-coldkey-hotkey-identities to staging July 24, 2025 19:38
@thewhaleking thewhaleking dismissed ibraheem-abe’s stale review July 24, 2025 19:38

The base branch was changed.

@thewhaleking thewhaleking merged commit e4732d8 into staging Jul 24, 2025
2 checks passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/transfer-all branch July 24, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants