Skip to content

Better arg naming + type annotations #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 1 commit into from
Aug 13, 2025
Merged

Better arg naming + type annotations #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions bittensor_cli/src/commands/sudo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
SubtensorInterface,
ProposalVoteData,
)
from scalecodec.types import GenericMetadataVersioned


# helpers and extrinsics
Expand Down Expand Up @@ -91,8 +92,8 @@ def search_metadata(
param_name: str,
value: Union[str, bool, float, list[float]],
netuid: int,
metadata,
pallet: str = DEFAULT_PALLET,
metadata: "GenericMetadataVersioned",
pallet_name: str = DEFAULT_PALLET,
) -> tuple[bool, Optional[dict]]:
"""
Searches the substrate metadata AdminUtils pallet for a given parameter name. Crafts a response dict to be used
Expand All @@ -103,7 +104,7 @@ def search_metadata(
value: the value to set the hyperparameter
netuid: the specified netuid
metadata: the subtensor.substrate.metadata
pallet: the name of the module to use for the query. If not set, the default value is DEFAULT_PALLET
pallet_name: the name of the module to use for the query. If not set, the default value is DEFAULT_PALLET

Returns:
(success, dict of call params)
Expand All @@ -125,7 +126,7 @@ def type_converter_with_retry(type_, val, arg_name):

call_crafter = {"netuid": netuid}

pallet = metadata.get_metadata_pallet(pallet)
pallet = metadata.get_metadata_pallet(pallet_name)
for call in pallet.calls:
if call.name == param_name:
if "netuid" not in [x.name for x in call.args]:
Expand Down
Loading