Merged
Conversation
S0AndS0
approved these changes
Apr 6, 2023
Rubberbandits
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per: paritytech/substrate#12891
Implicit call indexes are being deprecated. This is for user-safety reasons, among others, and makes the API more-stable.
The implicit indices were in the order declared in the file, where:
SubtensorModule.setWeightshas the call index suffix of00(hex); and,SubtensorModule.benchmarkDrainEmissionhas the call index suffix of31->49in decimal.Feel free to verify the numbering is correct