Move unit tests to the right place#1011
Merged
unconst merged 4 commits intodevnet-readyfrom Nov 21, 2024
Merged
Conversation
6284afc to
5540907
Compare
sam0x17
approved these changes
Nov 21, 2024
gztensor
approved these changes
Nov 21, 2024
Contributor
gztensor
left a comment
There was a problem hiding this comment.
I like this change: Now tests have access to private functions and cfg(test) also works.
unconst
approved these changes
Nov 21, 2024
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the tests from
pallet-subtensorandpallet-admin-utilsto the place, where Rust will see them as unit tests. That means, to make conditional compilation (cfg(test)) as well as access to private API and data fields in tests available. Currently these tests are located so, that Rust sees them as integration tests, which forces us to add public APIs needed to test private API.Basically, the changes are very simple:
pallets/subtensor/testsmoved topallets/subtensor/src/testspallets/admin-utils/testsmoved topallets/admin-utils/src/testsThis PR will allow further codebase clean ups. Particularly, removing the public API, which exists only for testing.
Related Issue(s)
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly