fix hard coded return_per_1000#1015
Merged
sam0x17 merged 13 commits intodevnet-readyfrom Jan 10, 2025
Merged
Conversation
sam0x17
previously approved these changes
Nov 25, 2024
cuteolaf
reviewed
Nov 27, 2024
Contributor
cuteolaf
left a comment
cuteolaf
left a comment
There was a problem hiding this comment.
looks good to me.
what about to add a test?
Contributor
Author
|
gztensor
requested changes
Dec 5, 2024
| let return_per_1000: U64F64 = if total_stake > U64F64::from_num(0) { | ||
| emissions_per_day | ||
| .saturating_mul(U64F64::from_num(0.82)) | ||
| .saturating_mul(U64F64::from_num(u16::MAX.saturating_sub(take.0))) |
Contributor
There was a problem hiding this comment.
Can we use .into() here to be more idiomatic?
gztensor
added
no-spec-version-bump
sam0x17
approved these changes
Jan 10, 2025
This was referenced Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix the issue #992
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.