Move chainspecs to a dedicated directory#1025
Merged
sam0x17 merged 7 commits intodevnet-readyfrom Nov 29, 2024
Merged
Conversation
gztensor
previously approved these changes
Nov 27, 2024
open-junius
approved these changes
Nov 28, 2024
Contributor
|
looks good to me. @rajkaramchedu the spec file folder is changed. we need update the doc https://docs.bittensor.com/subtensor-nodes. |
gztensor
approved these changes
Nov 29, 2024
|
I haven't looked at the code of this |
Contributor
Author
It's not. |
sam0x17
approved these changes
Nov 29, 2024
rajkaramchedu
pushed a commit
to opentensor/developer-docs
that referenced
this pull request
Nov 29, 2024
Updating this doc as per the change made in opentensor/subtensor#1025
This was referenced Dec 6, 2024
rajkaramchedu
pushed a commit
to opentensor/developer-docs
that referenced
this pull request
Dec 17, 2024
Updating this doc as per the change made in opentensor/subtensor#1025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves chain spec files into a dedicated directory
chainspecs.It also fixes
build_all_chainspecs.shscript by preventing genesis rewrites in the plain specs. And extends it to builddevnetspecs as well.The bootnode address fortestnetis changed to/dns/bootnode.test.chain.opentensor.ai/tcp/30333/p2p/12D3KooWEKUzXbgbJzCnAGcCLFwcEbDBp9ixa3aVVgJ5smiX1fSJ(requested byprop_physics)Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyAdditional Notes
Warning
As the script previously didn't handle keeping of genesis for plain specs, the plain specs genesis for
finneyandtestfinneydon't match the one in the raw specs.