Merged
Conversation
Contributor
🚨🚨🚨 HOTFIX DETECTED 🚨🚨🚨It looks like you are trying to merge a hotfix PR into . If this isn't what you wanted to do, and you just wanted to make a regular PR, please close this PR, base your changes off the branch and open a new PR into . If you are trying to merge a hotfix PR, please complete the following essential steps:
If you do not complete these steps, your hotfix may be inadvertently removed in the future when branches are promoted to |
sam0x17
approved these changes
Nov 28, 2024
distributedstatemachine
requested changes
Nov 28, 2024
Collaborator
distributedstatemachine
left a comment
There was a problem hiding this comment.
this change breaks alot of the existing tests .
failures:
test_do_revoke_child_singular_success
test_do_revoke_children_multiple_complex_scenario
test_do_revoke_children_multiple_non_existent_children
test_do_revoke_children_multiple_partial_revocation
test_do_revoke_children_multiple_success
test_do_set_child_singular_multiple_children
test_do_set_child_singular_old_children_cleanup
test_do_set_child_singular_proportion_edge_cases
test_do_set_children_multiple_old_children_cleanup
test_do_set_children_multiple_overwrite_existingcan you please patch these ?
Contributor
Author
Should be fixed with new |
gztensor
approved these changes
Nov 29, 2024
distributedstatemachine
approved these changes
Nov 29, 2024
unconst
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hotfixes the set_children rate limit of 2 tempos for a specific subnet.
Includes a test for the hotfix.
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly