Skip to content

Metagraph contract#1043

Merged
sam0x17 merged 11 commits intodevnet-readyfrom
metagraph-contract
Dec 11, 2024
Merged

Metagraph contract#1043
sam0x17 merged 11 commits intodevnet-readyfrom
metagraph-contract

Conversation

@open-junius
Copy link
Contributor

Description

The pr will close #1032 , create a precompile contract to get the metagraph data via eth rpc.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius requested a review from unconst as a code owner December 2, 2024 15:40
@open-junius open-junius self-assigned this Dec 2, 2024
@open-junius open-junius changed the title [WIP] Metagraph contract Metagraph contract Dec 4, 2024
@open-junius open-junius requested review from a team and gztensor December 4, 2024 12:08
@open-junius open-junius added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Dec 5, 2024

match method_id {
id if id == get_method_id("getUidCount(uint16)") => Self::get_uid_count(&method_input),
id if id == get_method_id("getIsSubnetRegistered(uint16)") => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this method to subnets precompile. It will be implemented in the issue #1067

// Include custom precompiles
mod balance_transfer;
mod ed25519;
mod metagraph;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

METAGRAPH_PRECOMPILE_INDEX also needs to be in used_addresses so that is_precompile works correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants