Merged
Conversation
camfairchild
reviewed
Dec 3, 2024
camfairchild
suggested changes
Dec 3, 2024
Contributor
camfairchild
left a comment
There was a problem hiding this comment.
One question, otherwise looks good
camfairchild
previously approved these changes
Dec 3, 2024
camfairchild
previously approved these changes
Dec 3, 2024
This reverts commit 796ffdb.
camfairchild
previously approved these changes
Dec 4, 2024
camfairchild
suggested changes
Dec 4, 2024
camfairchild
previously approved these changes
Dec 4, 2024
sam0x17
approved these changes
Dec 6, 2024
13 tasks
This was referenced Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pending children. See description in issue #1041
Related Issue(s)
Type of Change
Breaking Change
The behavior of
set_childrenchanges: Instead of setting children immediately, the children will be set in the subnet epoch after a cool down period (7200 blocks).Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
n/a
Additional Notes
n/a