Skip to content

Fix/network rate limit on zero block#1083

Merged
sam0x17 merged 3 commits intodevnet-readyfrom
fix/network-rate-limit-on-zero-block
Dec 10, 2024
Merged

Fix/network rate limit on zero block#1083
sam0x17 merged 3 commits intodevnet-readyfrom
fix/network-rate-limit-on-zero-block

Conversation

@camfairchild
Copy link
Contributor

Description

Fixes an issue with new chains where the register_network call is rate limited at the 0 block.

This also refactors the passes_rate_limit a bit with matching tests where applicable.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sam0x17
sam0x17 previously approved these changes Dec 10, 2024
@camfairchild camfairchild added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants