Skip to content

Fix/pending childkeys#1109

Merged
sam0x17 merged 5 commits intodevnet-readyfrom
fix/pending-childkeys
Dec 20, 2024
Merged

Fix/pending childkeys#1109
sam0x17 merged 5 commits intodevnet-readyfrom
fix/pending-childkeys

Conversation

@gztensor
Copy link
Contributor

Description

Fixes two issues:

  1. When sn registrations are disabled, pending childkeys are not applied
  2. Unable to revoke childkeys when stake is below minimum

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor requested a review from unconst as a code owner December 19, 2024 23:17
@gztensor gztensor added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Dec 19, 2024

// Test that setting childkeys requires minimum stake
#[test]
fn test_do_set_child_min_stake_check() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate? of L3636

Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants