Merged
Conversation
Contributor
Author
open-junius
added
no-spec-version-bump
gztensor
requested changes
Jan 17, 2025
|
|
||
| address constant ISUBNETS_ADDRESS = 0x0000000000000000000000000000000000000804; | ||
|
|
||
| interface ISubnets { |
Contributor
There was a problem hiding this comment.
This naming is a bit confusing. Please rename ISubnets to INeuron and files: subnets.sol/abi to neuron.sol/abi.
gztensor
reviewed
Jan 29, 2025
runtime/src/precompiles/neuron.rs
Outdated
| dispatch(handle, call, NEURON_CONTRACT_ADDRESS) | ||
| } | ||
|
|
||
| fn parse_netuid_hotkey_parameter(data: &[u8]) -> Result<(u16, [u8; 32]), PrecompileFailure> { |
Contributor
There was a problem hiding this comment.
Could you please move parse_pub_key and parse_netuid to the common space like you did with dispatch, for example, and use them here?
Contributor
Author
There was a problem hiding this comment.
moved both functions to mod
gztensor
approved these changes
Jan 30, 2025
sam0x17
approved these changes
Jan 30, 2025
13 tasks
This was referenced Feb 3, 2025
Merged
This was referenced May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.