Add prefunded ETH accounts to localnet chainspec#1116
Closed
ales-otf wants to merge 2 commits intodevnet-readyfrom
Closed
Add prefunded ETH accounts to localnet chainspec#1116ales-otf wants to merge 2 commits intodevnet-readyfrom
ales-otf wants to merge 2 commits intodevnet-readyfrom
Conversation
open-junius
reviewed
Dec 24, 2024
node/src/chain_spec/localnet.rs
Outdated
| ), | ||
| // ETH | ||
| ( | ||
| // Alith |
Contributor
There was a problem hiding this comment.
please add the ETH address in the doc
Contributor
Author
There was a problem hiding this comment.
Not sure where should I add it. Alith and Baltathar are easy to find, but I agree it would be good to have it in our docs too.
Contributor
There was a problem hiding this comment.
Adding the address in the comment I think would be helpful
Contributor
Author
There was a problem hiding this comment.
Adding the address in the comment I think would be helpful
Done.
open-junius
previously approved these changes
Dec 24, 2024
orriin
previously approved these changes
Jan 1, 2025
node/src/chain_spec/localnet.rs
Outdated
| ), | ||
| // ETH | ||
| ( | ||
| // Alith |
Contributor
There was a problem hiding this comment.
Adding the address in the comment I think would be helpful
ales-otf
added
the
skip-cargo-audit
Contributor
Author
|
added in #1184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two well known ETH accounts, Alith and Baltathar, to
localnetchainspec.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.