Skip to content

Fix/per 1k estimate always zero#1152

Merged
camfairchild merged 3 commits intodevnet-readyfrom
fix/per-1k-estimate-always-zero
Jan 21, 2025
Merged

Fix/per 1k estimate always zero#1152
camfairchild merged 3 commits intodevnet-readyfrom
fix/per-1k-estimate-always-zero

Conversation

@camfairchild
Copy link
Contributor

Description

Fixes an issue with the return per 1k TAO staked estimate always being zero. Also adds a test for this.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@camfairchild camfairchild requested a review from unconst as a code owner January 13, 2025 18:41
@camfairchild camfairchild added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jan 13, 2025
@camfairchild camfairchild requested a review from sam0x17 January 13, 2025 18:57
@sam0x17 sam0x17 removed the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Jan 14, 2025
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec version bump plz

@camfairchild camfairchild merged commit 09e205b into devnet-ready Jan 21, 2025
11 of 15 checks passed
@antonr-p2p
Copy link

@camfairchild @thewhaleking I don't see this issue in release notes still. Is it stuck in devnet-ready state? When can we expect it it mainnet release? Is it compatible with dTAO ?

@camfairchild
Copy link
Contributor Author

@camfairchild @thewhaleking I don't see this issue in release notes still. Is it stuck in devnet-ready state? When can we expect it it mainnet release? Is it compatible with dTAO ?

Please don't mention people unnecessarily.
This issue was closed in #1253
You can check for the code change in main or by trying to use it on the chain.

@antonr-p2p
Copy link

sorry to mention you directly, would escape this in future.
It was merged, but it's not released yet, as I see, right?

@thewhaleking thewhaleking deleted the fix/per-1k-estimate-always-zero branch April 16, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot get correct information for Bittensor validator

4 participants