make docker image builds trigger on key branches + ability to manually trigger#1168
Merged
unconst merged 5 commits intodevnet-readyfrom Jan 21, 2025
Merged
make docker image builds trigger on key branches + ability to manually trigger#1168unconst merged 5 commits intodevnet-readyfrom
unconst merged 5 commits intodevnet-readyfrom
Conversation
keithtensor
reviewed
Jan 21, 2025
| branches: | ||
| - devnet-ready | ||
| - devnet | ||
| - testnet |
Contributor
Author
There was a problem hiding this comment.
nope, for main people should use the releases, which also get deployed by this automatically
unconst
approved these changes
Jan 21, 2025
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so the current state of
devnet-ready,devnet, andtestnetis continuously deployed to docker hub using the branch names as the tag name.It also makes it so we can manually trigger branches or tags to deploy to docker hub based on a workflow dispatch. Currently it does not allow for deploying a branch/tag with a different branch/tag name in docker hub, however this could be added if it is desired later.