Skip to content

[RAO] [Fix] make sure to ensure burn reg before writing#1195

Merged
sam0x17 merged 4 commits intodevnet-readyfrom
fix/ensure-before-write-burned-reg
Jan 27, 2025
Merged

[RAO] [Fix] make sure to ensure burn reg before writing#1195
sam0x17 merged 4 commits intodevnet-readyfrom
fix/ensure-before-write-burned-reg

Conversation

@camfairchild
Copy link
Contributor

Description

This PR fixes an issue with burned reg where we swapped TAO (made a write) before ensuring everything was correct with the transaction. This would've taken TAO and burned it without giving the user a registration if something else failed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jan 27, 2025
@camfairchild camfairchild marked this pull request as ready for review January 27, 2025 17:30
@camfairchild camfairchild requested a review from unconst as a code owner January 27, 2025 17:30
@sam0x17 sam0x17 merged commit 4d7b612 into devnet-ready Jan 27, 2025
14 of 26 checks passed
This was referenced Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants