Skip to content

Ban saturating_div, to_num, and from_num#1198

Merged
sam0x17 merged 6 commits intodevnet-readyfrom
chore/safer-math
Jan 27, 2025
Merged

Ban saturating_div, to_num, and from_num#1198
sam0x17 merged 6 commits intodevnet-readyfrom
chore/safer-math

Conversation

@gztensor
Copy link
Contributor

@gztensor gztensor commented Jan 27, 2025

Description

Remove use of saturating_div, to_num, and from_num and replace with their safe (custom) versions: SafeDiv trait, saturating_to_num, and saturating_from_num respectively.

Note for CI: saturating_div, to_num, and from_num should be forbidden (except in tests, tests should be able to panic).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): Security update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor changed the title Ban saturating_div Ban saturating_div, to_num, and from_num Jan 27, 2025
@gztensor gztensor requested a review from sam0x17 January 27, 2025 19:49
sam0x17
sam0x17 previously approved these changes Jan 27, 2025
@gztensor gztensor marked this pull request as ready for review January 27, 2025 20:01
@gztensor gztensor requested a review from unconst as a code owner January 27, 2025 20:01
@gztensor gztensor requested a review from sam0x17 January 27, 2025 20:02
sam0x17
sam0x17 previously approved these changes Jan 27, 2025
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 27, 2025
@sam0x17 sam0x17 merged commit 948afbb into devnet-ready Jan 27, 2025
10 of 15 checks passed
@gztensor gztensor deleted the chore/safer-math branch January 27, 2025 21:51
This was referenced Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants