Feat/no more weird runtime api encoding#1227
Merged
sam0x17 merged 11 commits intodevnet-readyfrom Feb 4, 2025
Merged
Conversation
sam0x17
previously approved these changes
Feb 3, 2025
Merged
sam0x17
approved these changes
Feb 4, 2025
This was referenced Feb 4, 2025
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the runtime APIs to only use the actual types they are expecting, instead of encoding/decoding to
Vec<u8>.This means we can decode runtime API results using just the chain metadata, so we can more easily support future changes to the APIs.
This breaks old clients, but the timing with RAO makes it worthwhile, as old clients will break anyway.
Type of Change
Breaking Change
Clients upgrading should be grabbing their type information from the V15 Metadata on the chain.
They should also be able to see these runtime APIs listed there, with their expected input and output types, and the encoding for said types.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly