Skip to content

Add serve_axon extrinsic validation#1298

Merged
sam0x17 merged 3 commits intodevnet-readyfrom
feat/validate-serve-axon
Feb 14, 2025
Merged

Add serve_axon extrinsic validation#1298
sam0x17 merged 3 commits intodevnet-readyfrom
feat/validate-serve-axon

Conversation

@gztensor
Copy link
Contributor

Description

This will fail serve_axon extrinsics before inclusion in the block (benefits: footprint, taostats DB size growth rate).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

Only failing serve_axon extrinsics are affected. Instead of receiving extrinsic failure, one of CustomTransactionError values is returned immediately:

  • CustomTransactionError::HotKeyNotRegisteredInNetwork => 10,
  • CustomTransactionError::InvalidIpAddress => 11,
  • CustomTransactionError::ServingRateLimitExceeded => 12,
  • CustomTransactionError::InvalidPort => 13,

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor added the breaking-change This PR introduces a noteworthy breaking change label Feb 14, 2025
@gztensor gztensor requested a review from unconst as a code owner February 14, 2025 18:22
@github-actions
Copy link
Contributor

@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly!

sam0x17
sam0x17 previously approved these changes Feb 14, 2025
@sam0x17 sam0x17 merged commit a819d77 into devnet-ready Feb 14, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This PR introduces a noteworthy breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants