Merged
Conversation
sam0x17
approved these changes
Mar 10, 2025
camfairchild
approved these changes
Mar 11, 2025
This was referenced Mar 11, 2025
ales-otf
reviewed
Mar 11, 2025
| // 3. Ensure the remove operation from the coldkey is a success. | ||
| let tao_staked: u64 = | ||
| Self::remove_balance_from_coldkey_account(&coldkey, stake_to_be_added)?; | ||
| let tao_staked: I96F32 = |
Contributor
There was a problem hiding this comment.
we don't need this conversion, if we don't use the fee calculation from that function.
|
|
||
| // 5. Ensure the remove operation from the coldkey is a success. | ||
| let tao_staked: u64 = Self::remove_balance_from_coldkey_account(&coldkey, possible_stake)?; | ||
| let tao_staked: I96F32 = |
Contributor
There was a problem hiding this comment.
same thing about conversion here.
| hotkey: &T::AccountId, | ||
| alpha_estimate: I96F32, | ||
| ) -> u64 { | ||
| if (netuid == Self::get_root_netuid()) || (SubnetMechanism::<T>::get(netuid)) == 0 { |
Contributor
There was a problem hiding this comment.
parenthesis are unnecessary here. surprised it passed clippy.
| alpha_estimate: I96F32, | ||
| ) -> u64 { | ||
| if (netuid == Self::get_root_netuid()) || (SubnetMechanism::<T>::get(netuid)) == 0 { | ||
| DefaultStakingFee::<T>::get() |
Contributor
There was a problem hiding this comment.
just a personal preference, but it would be more readable with return statement here (guard style check), so you could avoid introducing else block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce flexible staking fees. Fees will be equal to the hotkey staking rewards worth of one epoch for the amount being staked/unstaked.
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly