Skip to content

add runtimeAPI for new dyn staking fee#1407

Merged
sam0x17 merged 7 commits intodevnet-readyfrom
feat/dyn-staking-fee-api
Mar 13, 2025
Merged

add runtimeAPI for new dyn staking fee#1407
sam0x17 merged 7 commits intodevnet-readyfrom
feat/dyn-staking-fee-api

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Mar 13, 2025

Description

Adds a runtime API

stakeInfoRuntimeApi.getStakeFee( 
  origin: Option<(AccountId32, u16)>,
  origin_coldkey_account: AccountId32,
  destination: Option<(AccountId32, u16)>,
  destination_coldkey_account: AccountId32,
  amount: u64
) -> u64 

to get the staking fee for a staking operation.

The extra params are for future-proofing.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

sam0x17
sam0x17 previously approved these changes Mar 13, 2025
@camfairchild camfairchild requested a review from sam0x17 March 13, 2025 17:36
sam0x17
sam0x17 previously approved these changes Mar 13, 2025
@camfairchild camfairchild requested a review from sam0x17 March 13, 2025 18:24
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 13, 2025
@sam0x17 sam0x17 merged commit 5fe2cf5 into devnet-ready Mar 13, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants