Merged
Conversation
ales-otf
reviewed
Apr 3, 2025
Contributor
ales-otf
left a comment
There was a problem hiding this comment.
just minor stuff from me, feel free to ignore if you wish
l0r1s
reviewed
Apr 3, 2025
sam0x17
reviewed
Apr 8, 2025
.github/workflows/evm-tests.yml
Outdated
Comment on lines
+5
to
+10
| branches: | ||
| - devnet | ||
| - devnet-ready | ||
| - testnet | ||
| - testnet-ready | ||
| - main |
Contributor
There was a problem hiding this comment.
let's just take out this entire line, we want it to run on all PRs
Collaborator
There was a problem hiding this comment.
My bad then @open-junius ! Sorry for the change!
sam0x17
approved these changes
Apr 8, 2025
gztensor
approved these changes
Apr 11, 2025
camfairchild
suggested changes
Apr 11, 2025
Contributor
There was a problem hiding this comment.
Please restrict branches to trigger
https://github.com/opentensor/subtensor/pull/1422/files#r2039631846
Contributor
Author
#1422 (comment) please check this comment. |
ales-otf
approved these changes
Apr 11, 2025
This was referenced Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.