Skip to content

divs are minimum zero#1481

Merged
sam0x17 merged 7 commits intodevnet-readyfrom
hotfix/no-negative-divs
Mar 28, 2025
Merged

divs are minimum zero#1481
sam0x17 merged 7 commits intodevnet-readyfrom
hotfix/no-negative-divs

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Mar 28, 2025

Description

Hotfixes an issue with divs possibly being negative.
Adds a .max(zero) during the calculation of distribution.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions github-actions bot added hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet run-bittensor-e2e-tests labels Mar 28, 2025
@camfairchild camfairchild changed the base branch from main to devnet-ready March 28, 2025 18:07
@opentensor opentensor deleted a comment from github-actions bot Mar 28, 2025
@JohnReedV JohnReedV added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 28, 2025
@sam0x17 sam0x17 merged commit 4ea7fb1 into devnet-ready Mar 28, 2025
55 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants