Change update_moving_price() function#1496
Merged
sam0x17 merged 1 commit intodevnet-readyfrom Apr 2, 2025
Merged
Conversation
- change the function to use FirstEmissionBlockNumber parameter instead of NetworkRegisteredAt.
camfairchild
approved these changes
Apr 2, 2025
sam0x17
approved these changes
Apr 2, 2025
This was referenced Apr 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're changing
update_moving_price()function to useFirstEmissionBlockNumberparameter instead ofNetworkRegisteredAt. We need this change to take another block from the subnet lifecycle to calculate the moving price. Initially, we used the registration block, but the block of the invocation ofstart_call()function is more valid.start_call()setsFirstEmissionBlockNumberstorage map and emits the related event.Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyAdditional Notes
The new code expects
start_call()to be called beforeupdate_moving_price(); otherwise, thefirst_emissions_blockdefaults to zero. The block affecting the calculation isFirstEmissionBlockNumberminus one block becausestart_blocksets FirstEmissionBlockNumber to the next block instead of the current one.