Fix docker image overwrites by adding platform to image tag#1508
Merged
sam0x17 merged 2 commits intodevnet-readyfrom Apr 4, 2025
Merged
Fix docker image overwrites by adding platform to image tag#1508sam0x17 merged 2 commits intodevnet-readyfrom
sam0x17 merged 2 commits intodevnet-readyfrom
Conversation
sam0x17
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR alters the
docker.ymlby introducing additional tags related to the target platform when building docker images and pushing them to the repository. The previous changes to the workflow split the multiplatform into two separate jobs; however, that caused image overwrites since the image tags were the same. The fix changes that and produces these results:https://github.com/opentensor/subtensor/pkgs/container/subtensor/388517732?tag=ci-platform-fix-amd64
https://github.com/opentensor/subtensor/pkgs/container/subtensor/388656587?tag=ci-platform-fix-arm64
Type of Change