Skip to content

Fix docker image overwrites by adding platform to image tag#1508

Merged
sam0x17 merged 2 commits intodevnet-readyfrom
ci-platform-fix
Apr 4, 2025
Merged

Fix docker image overwrites by adding platform to image tag#1508
sam0x17 merged 2 commits intodevnet-readyfrom
ci-platform-fix

Conversation

@shamil-gadelshin
Copy link
Collaborator

Description

This PR alters the docker.yml by introducing additional tags related to the target platform when building docker images and pushing them to the repository. The previous changes to the workflow split the multiplatform into two separate jobs; however, that caused image overwrites since the image tags were the same. The fix changes that and produces these results:

https://github.com/opentensor/subtensor/pkgs/container/subtensor/388517732?tag=ci-platform-fix-amd64
https://github.com/opentensor/subtensor/pkgs/container/subtensor/388656587?tag=ci-platform-fix-arm64

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (CI workflow fix):

@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 4, 2025
sam0x17
sam0x17 previously approved these changes Apr 4, 2025
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sam0x17 sam0x17 merged commit 8091fb4 into devnet-ready Apr 4, 2025
50 checks passed
@sam0x17 sam0x17 mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants