Skip to content

Deduplicate subnet symbols#1514

Merged
sam0x17 merged 3 commits intodevnet-readyfrom
fix/sn-symbols
Apr 7, 2025
Merged

Deduplicate subnet symbols#1514
sam0x17 merged 3 commits intodevnet-readyfrom
fix/sn-symbols

Conversation

@gztensor
Copy link
Contributor

@gztensor gztensor commented Apr 7, 2025

Description

Remove duplicates from sn symbols

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 7, 2025
@mobiusfund
Copy link

This is the owner of subnet 88. Please do NOT change our symbol eihwaz. Thanks!

@mobiusfund
Copy link

This is not a big deal. Just want to make sure we are keeping the ᛇ eihwaz symbol currently listed under btcli for subnet 88. We really don’t want to be associated with the “bi” symbol from discord channel #88

@sam0x17 sam0x17 merged commit 038a21f into devnet-ready Apr 7, 2025
49 of 50 checks passed
@sam0x17
Copy link
Contributor

sam0x17 commented Oct 30, 2025

This is not a big deal. Just want to make sure we are keeping the ᛇ eihwaz symbol currently listed under btcli for subnet 88. We really don’t want to be associated with the “bi” symbol from discord channel #88

sorry we missed this, fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants